Rename ContainerViewController to WorkflowHostingController #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
force-pushed
the
kve/container-rename
branch
from
87a46f8 to
edb6f17
Compare
mjohnson12
approved these changes
Sep 26, 2022
dhavalshreyas
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
ContainerViewControllertoWorkflowHostingControllerto (a) be a less generic name (basically any parent view controller is a "container") / explain what the VC is containing/hosting, and (b) aligns us more closely with SwiftUI'sUIHostingControllernaming.I've left the old name as a deprecated name – we can remove it in a 2.0 (assuming we follow proper semver?) in perhaps a couple months. I'll migrate POS / etc.
Checklist