[performance]: disable logging by default & add logging configuration #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mjohnson12
approved these changes
Aug 18, 2022
jamieQ
commented
Aug 18, 2022
| static let workflow = OSLog(subsystem: "com.squareup.Workflow", category: "Workflow") | ||
|
|
||
| /// The active log handle to use when logging. Defaults to the shared `.disabled` handle. | ||
| static var active: OSLog = .disabled |
There was a problem hiding this comment.
cribbing the analogous Blueprint approach to this
There was a problem hiding this comment.
Note: Recently changed this a bit, in particular making this a private (set) and checking isEnabled and bailing early from methods: square/Blueprint#364
| } | ||
|
|
||
| /// Configuration options used to determine which activities are logged. | ||
| public static var config: Config = .debug |
There was a problem hiding this comment.
maybe should default to the reduced logging config? 🤷
kyleve
reviewed
Aug 18, 2022
kyleve
approved these changes
Aug 18, 2022
jamieQ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Changes
example XCTest run after disabling logging:
Checklist