Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce performInitialUpdate to allow disabling updates during view controller building #147

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

kyleve
Copy link
Contributor

@kyleve kyleve commented Jun 22, 2022

This change allows disabling the initial update that occurs within buildViewController, which is not desired for container view controllers in many cases: When your container view controller (eg, nav stack, tab bar) creates its DescribedViewControllers in init, they are already updated with their content. Disabling the update during buildViewController allows us to skip duplicate updates to them that end up occurring immediately after.

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@kyleve kyleve merged commit 62774aa into main Jun 23, 2022
@kyleve kyleve deleted the kve/performInitialUpdate branch June 23, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants