Always remove child view controller from DescribedViewController #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kyleve
approved these changes
Jan 8, 2022
kylebshr
commented
Jan 8, 2022
| XCTAssertEqual((describedViewController.currentViewController as? MessageViewController)?.message, "Test") | ||
| XCTAssertFalse(describedViewController.isViewLoaded) | ||
| XCTAssertFalse(describedViewController.currentViewController.isViewLoaded) | ||
| XCTAssertNil(describedViewController.currentViewController.parent) | ||
| XCTAssertEqual(describedViewController.currentViewController.parent, describedViewController) |
There was a problem hiding this comment.
We actually do want this child-parent relationship set up, which is also fixed
kylebshr
commented
Jan 8, 2022
| @@ -108,10 +108,11 @@ | |||
|
|
|||
| // Then | |||
| XCTAssertNotEqual(initialChildViewController, describedViewController.currentViewController) | |||
| XCTAssertNil(initialChildViewController.parent) | |||
There was a problem hiding this comment.
This test validates the fix. It fails on main.
tyten
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the child of a
DescribedViewControllerwasn't removed even when thecurrentViewControllerwas replaced. This issue was introduced in #108 - we started setting up the parent-child relationship in the init, but only remove the child if our view is loaded. In the case where an update happens before the view is loaded, that initial child is never removed.The left-behind relationship and view was causing issues where (correct) assumptions about the view and view controller hierarchy were invalid, causing this crash: https://square.slack.com/archives/CTJ4UNLHF/p1641510705024100
Thanks @tyten and @kyleve for helping debug!
Checklist