Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Xcode 12.5.1 / iOS 14.5 for GitHub actions #109

Merged
merged 3 commits into from
Dec 10, 2021
Merged

Use Xcode 12.5.1 / iOS 14.5 for GitHub actions #109

merged 3 commits into from
Dec 10, 2021

Conversation

n8chur
Copy link
Collaborator

@n8chur n8chur commented Dec 9, 2021 •
edited
Loading

The macos-latest (11) GitHub environment no longer provides Xcode 11.4.

Checklist

  • Unit Tests
  • UI Tests
  • Snapshot Tests (iOS only)
  • I have made corresponding changes to the documentation

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@n8chur n8chur force-pushed the westin/fix-ci branch 4 times, most recently from 8c99128 to 4ca6220 Compare December 9, 2021 21:54
@n8chur n8chur changed the title Use Xcode 11.4.1 Use Xcode 12.5.1 Dec 9, 2021
@n8chur n8chur changed the title Use Xcode 12.5.1 Use Xcode 12.5.1 / iOS 14.5 for GitHub actions Dec 9, 2021
@n8chur n8chur marked this pull request as ready for review December 9, 2021 22:04
@n8chur n8chur marked this pull request as draft December 9, 2021 22:09
@n8chur n8chur marked this pull request as ready for review December 9, 2021 22:37
@n8chur
Copy link
Collaborator Author

n8chur commented Dec 9, 2021

Not sure what's going on with the snapshot test changes—it looks like the resolution changed for some reason?

Before After
Screen Shot 2021-12-09 at 2 40 09 PM Screen Shot 2021-12-09 at 2 40 29 PM

dhavalshreyas
dhavalshreyas approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@dhavalshreyas dhavalshreyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@n8chur n8chur merged commit 3190bf9 into square:main Dec 10, 2021
@n8chur n8chur deleted the westin/fix-ci branch December 10, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhavalshreyas dhavalshreyas dhavalshreyas approved these changes

@kyleve kyleve kyleve approved these changes

@JustinDSN JustinDSN Awaiting requested review from JustinDSN

@AquaGeek AquaGeek Awaiting requested review from AquaGeek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n8chur @CLAassistant @kyleve @dhavalshreyas