Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ReactiveSwift imports #103

Merged
merged 1 commit into from
Oct 28, 2021
Merged

Conversation

dhavalshreyas
Copy link
Contributor

No description provided.

Copy link
Collaborator

@JustinDSN JustinDSN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@@ -15,7 +15,6 @@
*/

import Dispatch
import ReactiveSwift
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an extraneous dependency declaration somewhere that allowed this all to compile?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused imports are not compile time errors.

@dhavalshreyas dhavalshreyas merged commit 8fd3fce into main Oct 28, 2021
@dhavalshreyas dhavalshreyas deleted the dhaval/rmUnnecessaryImports branch October 28, 2021 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants