Fixed Swift 5.6+ compiler crash in TaskWorkflow

Removing the closure to a Task and just passing in the Task to the TaskWorkflow fixes the compiler crash.
square · Jun 17, 2022 · 97296d0 · 97296d0
1 parent 2789389
commit 97296d0
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 11 deletions.
diff --git a/WorkflowConcurrency/Sources/TaskWorkflow.swift b/WorkflowConcurrency/Sources/TaskWorkflow.swift
@@ -21,7 +21,7 @@ import Workflow
 @available(iOS 13.0, macOS 10.15, *)
 extension Task: AnyWorkflowConvertible where Failure == Never {
     public func asAnyWorkflow() -> AnyWorkflow<Void, Success> {
-        TaskWorkflow(taskProvider: { self }).asAnyWorkflow()
+        TaskWorkflow(task: self).asAnyWorkflow()
     }
 }
 
@@ -31,18 +31,17 @@ struct TaskWorkflow<Value>: Workflow {
     public typealias State = Void
     public typealias Rendering = Void
 
-    var taskProvider: () -> Task<Value, Never>
+    private let task: Task<Value, Never>
 
-    public init(taskProvider: @escaping () -> Task<Value, Never>) {
-        self.taskProvider = taskProvider
+    public init(task: Task<Value, Never>) {
+        self.task = task
     }
 
     public func render(state: State, context: RenderContext<TaskWorkflow>) -> Rendering {
         let sink = context.makeSink(of: AnyWorkflowAction.self)
-        context.runSideEffect(key: "") { [taskProvider] lifetime in
-            let providedTask = taskProvider()
-            let task = Task {
-                let output = await providedTask.value
+        context.runSideEffect(key: "") { [task] lifetime in
+            let sideEffectTask = Task {
+                let output = await task.value
                 if Task.isCancelled { return }
                 let action = AnyWorkflowAction<TaskWorkflow>(sendingOutput: output)
                 DispatchQueue.main.async {
@@ -51,8 +50,8 @@ struct TaskWorkflow<Value>: Workflow {
             }
 
             lifetime.onEnded {
+                sideEffectTask.cancel()
                 task.cancel()
-                providedTask.cancel()
             }
         }
     }

diff --git a/WorkflowConcurrency/Tests/TaskTests.swift b/WorkflowConcurrency/Tests/TaskTests.swift
@@ -24,9 +24,9 @@ import XCTest
 class PublisherTests: XCTestCase {
     func test_output() {
         let host = WorkflowHost(
-            workflow: TaskWorkflow(taskProvider: {
+            workflow: TaskWorkflow(task:
                 Task { "hello world" }
-            })
+            )
         )
 
         let expectation = XCTestExpectation()