Eliminates the useless type property from ViewEnvironmentKey.
#999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjrjr
force-pushed
the
ray/less-stupid-keys
branch
2 times, most recently
from
9322da4 to
91fd086
Compare
rjrjr
force-pushed
the
ray/less-stupid-keys
branch
from
91fd086 to
3bb7596
Compare
|
Kdoc update made me notice that |
0legg
reviewed
May 15, 2023
workflow-ui/core-common/src/main/java/com/squareup/workflow1/ui/ViewEnvironment.kt
Show resolved
Hide resolved
0legg
approved these changes
May 16, 2023
| * Defines a value type [T] that can be provided by a [ViewEnvironment] map, | ||
| * and specifies its [default] value. | ||
| * | ||
| * It is hard to imagine a useful implementation of this that is not a Kotlin `object`. |
There was a problem hiding this comment.
Should we make a lint rule to enforce this convention?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.