Mark runningWorker with no output as @Deprecated #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I totally forgot about this.. I think I'm failing some tests because of lint errors. I'll address this ASAP so we can get it merged in and it stops collecting dust. |
crocsandcoffee
force-pushed
the
OG/issue-994
branch
from
62508de to
eff6703
Compare
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@steve-the-edwards I ended up suppressing deprecated warnings in the tests that were causing CI to fail (since we treat warnings as errors). Let me know what you think. It looked like these tests are specifically trying to test functionality of the method I am deprecating - so it makes sense to leave them as-is until the deprecated method is actually removed (and then we just delete those tests with the suppressions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #994