Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readability tweaks to runtime #986

Merged
merged 2 commits into from
Apr 10, 2023
Merged

Readability tweaks to runtime #986

merged 2 commits into from
Apr 10, 2023

Conversation

rjrjr
Copy link
Contributor

@rjrjr rjrjr commented Apr 8, 2023

  1. Rename tick to onNextAction
  2. Less confusing and slightly less hacky action handling return types

rjrjr added 2 commits April 7, 2023 15:24
@rjrjr
Rename tick to onNextAction
472d290 
It has been the wrong, confusing name for years. It doesn't tick anything, it adds select clauses.
@rjrjr
Less confusing and slightly less hacky action handling return types
86c19c9
@rjrjr rjrjr requested a review from a team as a code owner April 8, 2023 00:59
@rjrjr rjrjr requested a review from zach-klippenstein as a code owner April 8, 2023 00:59
steve-the-edwards
steve-the-edwards approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@steve-the-edwards steve-the-edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Every time I look at this code I think we need to do this but then I don't.

@steve-the-edwards steve-the-edwards merged commit 451d2e2 into main Apr 10, 2023
@steve-the-edwards steve-the-edwards deleted the ray/a-little-more-readable-at-least branch April 10, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steve-the-edwards steve-the-edwards steve-the-edwards approved these changes

@RBusarow RBusarow RBusarow approved these changes

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein zach-klippenstein is a code owner

Assignees

@steve-the-edwards steve-the-edwards

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjrjr @steve-the-edwards @RBusarow