split the publish-snapshot job into smaller steps, with gradle/gradle-build-action
#972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle-build-action` We've been getting timeouts at the 35 minute mark. A single step was doing all the work, running `./gradlew build` and then `./gradlew publish`. The build task runs all checks, including Android Lint, so it ran for too long. And none of it was using a build cache. With the way `gradle/gradle-build-action` works, nothing is actually uploaded until after the step has completed successfully. So if a step times out, all the incremental progress it made will be lost. For this reason, it's best to break very long-running steps down into smaller ones. That way, even if the very first run times out, subsequent runs will save time by using its cache.
rjrjr
approved these changes
Mar 20, 2023
| @@ -132,7 +135,7 @@ jobs : | |||
| name : Check with Gradle | |||
| with : | |||
| arguments : | | |||
| allTests test apiCheck checkVersionIsSnapshot lint lintKotlin jvmWorkflowNodeBenchmarkJar --stacktrace --continue | |||
| allTests test apiCheck checkVersionIsSnapshot lint lintKotlin jvmWorkflowNodeBenchmarkJar --continue | |||
There was a problem hiding this comment.
Are we running checkVersionIsSnapshot twice?
steve-the-edwards
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been getting timeouts at the 35 minute mark. A single step was doing all the work, running
./gradlew buildand then./gradlew publish. The build task runs all checks, including Android Lint, so it ran for too long. And none of it was using a build cache.With the way
gradle/gradle-build-actionworks, nothing is actually uploaded until after the step has completed successfully. So if a step times out, all the incremental progress it made will be lost. For this reason, it's best to break very long-running steps down into smaller ones. That way, even if the very first run times out, subsequent runs will save time by using its cache.