Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Renovate groups for Kotlin and androidx-lifecycle updates #947

Merged
merged 1 commit into from
Feb 24, 2023

Conversation

RBusarow
Copy link
Collaborator

With package grouping, Renovate will combine multiple update PRs into a single PR. This is really nice for dependencies which must be updated together, like Kotlin and KSP.

If only some packages in the group have updates, then Renovate will make a PR for those packages by themselves.

@@ -113,6 +113,8 @@ androidx-appcompat = { module = "androidx.appcompat:appcompat", version.ref = "a

androidx-cardview = { module = "androidx.cardview:cardview", version.ref = "androidx-cardview" }

androidx-compose-compiler = { module = "androidx.compose.compiler:compiler", version.ref = "androidx-compose-compiler" }
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the version reference in the Android convention plugin, but that isn't enough for Renovate to pick it up. So by defining the actual maven artifact here, Renovate will see it and include it in its update checks.

Copy link
Contributor

@steve-the-edwards steve-the-edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@RBusarow RBusarow marked this pull request as ready for review February 24, 2023 00:24
@RBusarow RBusarow requested review from a team and zach-klippenstein as code owners February 24, 2023 00:24
@RBusarow RBusarow added this pull request to the merge queue Feb 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2023
@RBusarow RBusarow added this pull request to the merge queue Feb 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2023
@RBusarow RBusarow added this pull request to the merge queue Feb 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2023
@RBusarow RBusarow added this pull request to the merge queue Feb 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 24, 2023
@RBusarow RBusarow added this pull request to the merge queue Feb 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 24, 2023
@RBusarow RBusarow merged commit f50a42f into main Feb 24, 2023
@RBusarow RBusarow deleted the rbusarow/renovate_grouping branch February 24, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants