Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close dialogs even if the managing view is never attached. #941

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Close dialogs even if the managing view is never attached. #941

merged 1 commit into from
Feb 23, 2023

Conversation

rjrjr
Copy link
Contributor

@rjrjr rjrjr commented Feb 21, 2023

No description provided.

pyricau
pyricau approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@pyricau pyricau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE FIX!

@rjrjr rjrjr marked this pull request as ready for review February 22, 2023 01:36
@rjrjr rjrjr requested review from a team and zach-klippenstein as code owners February 22, 2023 01:36
steve-the-edwards
steve-the-edwards approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@steve-the-edwards steve-the-edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

...-ui/core-android/src/main/java/com/squareup/workflow1/ui/androidx/WorkflowAndroidXSupport.kt Show resolved Hide resolved
@rjrjr rjrjr force-pushed the ray/dialog-failsafe branch from b8ceffb to b62f88f Compare February 22, 2023 20:08
@rjrjr rjrjr changed the base branch from main to v1.9.0-beta02-release February 22, 2023 20:09
@rjrjr
Copy link
Contributor Author

rjrjr commented Feb 22, 2023

Expecting to publish this via branch v1.9.0-beta02-release. Running internal test suite against it first.

@rjrjr rjrjr merged commit e8e862e into v1.9.0-beta02-release Feb 23, 2023
@rjrjr rjrjr deleted the ray/dialog-failsafe branch February 23, 2023 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steve-the-edwards steve-the-edwards steve-the-edwards approved these changes

@pyricau pyricau pyricau approved these changes

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein zach-klippenstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjrjr @pyricau @steve-the-edwards