Add Configurable Recursive Rendering to Performance Poetry #903
Conversation
steve-the-edwards
force-pushed
the
sedwards/perf-experiments
branch
4 times, most recently
from
6003718 to
411044e
Compare
steve-the-edwards
changed the title
steve-the-edwards
force-pushed
the
sedwards/perf-experiments
branch
2 times, most recently
from
f8eb139 to
b5e9831
Compare
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
|
The commit message should be a comment in the code somewhere. I don't understand this:
It looked like you were rendering children for breadth as well as depth, just that most of them ignored output. What do you actually mean by "provides a rendering"? |
All of them are 'rendered' from the POV of Workflow runtime, but only 1 path of the tree (the (n-1)th child of each depth) actually returns the rendering from |
|
steve-the-edwards
force-pushed
the
sedwards/perf-experiments
branch
from
b5e9831 to
2809f01
Compare
| * simultaneously and tries to represent a scenario of multiple Workflows listening to the same | ||
| * action. | ||
| * [traceRenderingPasses], [traceFrameLatency], [traceEventLatency] are all flags to add | ||
| * instrumentation for different performance measurements. |
Do the other ones render null? Is that mimicking a pattern in our prod code? |
They don't render null, we just don't do anything with their renderings. |
| @@ -50,9 +51,11 @@ class PerformancePoemsBrowserWorkflow( | |||
| private val isLoading: MutableStateFlow<Boolean>, | |||
| ) : | |||
| PoemsBrowserWorkflow, | |||
| StatefulWorkflow<List<Poem>, State, Unit, OverviewDetailScreen>() { | |||
| StatefulWorkflow<Pair<Pair<Int, Int>, List<Poem>>, State, Unit, OverviewDetailScreen>() { | |||
There was a problem hiding this comment.
Replacing Pair<Int, Int> with a data class or a typealias and some extension methods would make this a lot easier to read.
| val nextProps = renderProps.copy( | ||
| first = renderProps.first.first - 1 to breadth | ||
| ) | ||
| // ignore the siblings. |
There was a problem hiding this comment.
This comment confuses me. Is it about the noAction()? If so, how about put it there and say "Ignore sibling output."? Be good to say why we're ignoring it too.
Customizable via intent. Depth is how many times to recursively render PerformancePoemsBrowserWorkflow in the tree. Breadth is how many times to repeate rendering of PerformancePoemsBrowserWorkflow horizontally in the tree. Only one path of the tree provides a rendering.
steve-the-edwards
force-pushed
the
sedwards/perf-experiments
branch
from
2809f01 to
96d5579
Compare
Customizable via intent.
Depth is how many times to recursively render PerformancePoemsBrowserWorkflow in the tree.
Breadth is how many times to repeate rendering of PerformancePoemsBrowserWorkflow horizontally in the tree.
Only one path of the tree provides a rendering.