Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update kotlin to 1.6.21 #873

Merged
merged 2 commits into from
Sep 22, 2022
Merged

update kotlin to 1.6.21 #873

merged 2 commits into from
Sep 22, 2022

Conversation

RBusarow
Copy link
Collaborator

@RBusarow RBusarow commented Sep 12, 2022 •
edited
Loading

  • run Square's internal CI against a snapshot (and pass)

steve-the-edwards
steve-the-edwards approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@steve-the-edwards steve-the-edwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@rjrjr
Copy link
Contributor

rjrjr commented Sep 13, 2022 •
edited
Loading

@RBusarow Presuming it passes the internal suite, I'd like to get #872 released on its own before this, to minimize the swirl around the AlertDialog fix. Should be able to do that today. Is that going to get in your way?

@RBusarow
Copy link
Collaborator Author

@RBusarow Presuming it passes the internal suite, I'd like to get #872 released on its own before this, to minimize the swirl around the AlertDialog fix. Should be able to do that today. Is that going to get in your way?

We have a handful of failing shards, but at first glance I don't think they're related to this update. I won't be digging into that more until late today at the earliest, so I have no problem in holding back a bit. :)

@RBusarow
switch "workflow-runtime's "-Xfriend-paths=__" compiler argument to…
3687b54 
… an associated build

"-Xfriend-paths=____" no longer works for accessing internal declarations from other compilation units.  The replacement for this is to use `KotlinCompilation.associateWith(...)`.

https://youtrack.jetbrains.com/issue/KTIJ-7662/IDE-support-internal-visibility-introduced-by-associated-compilations
@RBusarow
Copy link
Collaborator Author

@rjrjr @steve-the-edwards I've added a second commit to drop the "-Xfriend-paths=___" compiler argument for :workflow-runtime. WorkflowNode was no longer accessible to WorkflowNodeBenchmark after the Kotlin update. Instead, I'm using the shiny newish workflowNodeCompilation.associateWith(main).

1256b0a

@RBusarow RBusarow marked this pull request as ready for review September 21, 2022 16:51
@RBusarow RBusarow requested review from a team and zach-klippenstein as code owners September 21, 2022 16:51
@RBusarow RBusarow merged commit d35c70d into main Sep 22, 2022
@RBusarow RBusarow deleted the rick/kotlin_1.6.21 branch September 22, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steve-the-edwards steve-the-edwards steve-the-edwards approved these changes

@rjrjr rjrjr rjrjr approved these changes

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein zach-klippenstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RBusarow @rjrjr @steve-the-edwards