Add Simultaneous Worker Listener Actions #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
force-pushed
the
sedwards/add-simultaneous
branch
from
9eb7e3a to
774f44c
Compare
steve-the-edwards
force-pushed
the
sedwards/add-simultaneous
branch
2 times, most recently
from
1277405 to
a41659e
Compare
|
Don't want to merge this yet as the Frame Timeout instrumentation tests are flaky. |
|
Still marked as Draft, do you want us to review it yet? |
Tomorrow. I'm going to take out the test re-enabling and do that separately. |
steve-the-edwards
force-pushed
the
sedwards/add-simultaneous
branch
from
a41659e to
13f4bf1
Compare
Simulates multiple workers subscribing to same event and then triggering multiple actions all queued.
steve-the-edwards
force-pushed
the
sedwards/add-simultaneous
branch
from
13f4bf1 to
612e105
Compare
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
RBusarow
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproduces the scenario where you have multiple Workers waiting for the same result and all produce an action. In the RenderPerAction (original runtime) this creates a lot of unnecessary renders.