Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KMP target for iosSimulatorArm64 #854

Merged

Conversation

bnvinay92
Copy link
Contributor

@bnvinay92 bnvinay92 commented Aug 1, 2022

The coroutines bump to 1.6.4 lets us add the iosSimulatorArm64 target to run simulators on M1 macs.

@bnvinay92 bnvinay92 requested review from a team and zach-klippenstein as code owners August 1, 2022 21:04
@@ -5,28 +5,15 @@ plugins {

kotlin {
jvm { withJava() }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a quick comment here to look at the kotlin-multiplatform include for the other KMP targets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imported the function from buildSrc instead.

@bnvinay92 bnvinay92 force-pushed the bnvinay92/iosSimulatorArm64 branch from 1b689a5 to 76e7da5 Compare August 4, 2022 07:06
@steve-the-edwards steve-the-edwards merged commit 7fe199f into square:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants