Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transitive dependency cleanup #848

Merged
merged 2 commits into from
Aug 3, 2022
Merged

transitive dependency cleanup #848

merged 2 commits into from
Aug 3, 2022

Conversation

RBusarow
Copy link
Collaborator

Mostly following the recommendations of DAGP, these changes:

  • explicitly declare dependencies upon the transitive dependencies from other dependencies
  • remove unused dependencies
  • switch implementation with api and vice versa where necessary
    • I ignored api dependencies which "should" be implementation anywhere there's a comment saying they should be api
    • I also just left things as api in the internal testing modules

The first commit just sorts all dependency declarations. See the second commit for the actual changes.

fixes #847

@RBusarow RBusarow force-pushed the rick/dependency_cleanup_2 branch 2 times, most recently from acd44d9 to a80b221 Compare July 29, 2022 19:21
- ignored recommentations to make things `implementation` where there's a comment specifically saying to leave it as `api`
- ignored false positives saying to remove `:workflow-tracing` dependencies from sample projects
@RBusarow RBusarow force-pushed the rick/dependency_cleanup_2 branch from a80b221 to 5d51217 Compare August 1, 2022 15:54
@RBusarow RBusarow marked this pull request as ready for review August 1, 2022 15:54
@RBusarow RBusarow requested review from a team and zach-klippenstein as code owners August 1, 2022 15:54
@RBusarow RBusarow merged commit ff89cd0 into main Aug 3, 2022
@RBusarow RBusarow deleted the rick/dependency_cleanup_2 branch August 3, 2022 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

androidx-savedstate is part of the ABI in workflow-ui-core-android, but isn't a compile dependency in the pom
3 participants