Upgrade coroutines to 1.6.4 (including coroutines.test changes) #817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For non-test use we had already migrated from
offer
totrySend
for channels.For tests (the larger change), see the test migration guide followed here: https://github.com/Kotlin/kotlinx.coroutines/blob/master/kotlinx-coroutines-test/MIGRATION.md
This has been tested successfully internally in Square POS via a snapshot.
Regarding whether we should convert all
runBlocking
torunTest
when used in tests, its a choice for each situation (we have converted many but not all). See Dmitry Khalanskiy's (coroutines maintainer) to that question: