Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves TextController test coverage #1225

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Improves TextController test coverage #1225

merged 1 commit into from
Oct 29, 2024

Conversation

jkwiz
Copy link
Collaborator

@jkwiz jkwiz commented Oct 29, 2024 •
edited
Loading

Some tests for TextController were added in #1224 to support equals and hashCode, and this improves the coverage.

@jkwiz jkwiz requested a review from rjrjr October 29, 2024 22:32
@jkwiz jkwiz marked this pull request as ready for review October 29, 2024 22:57
@jkwiz jkwiz requested review from zach-klippenstein and a team as code owners October 29, 2024 22:57
@rjrjr rjrjr merged commit b91ad6c into main Oct 29, 2024
30 checks passed
@rjrjr rjrjr deleted the joshwilliams/text-controller-test-coverage branch October 29, 2024 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjrjr rjrjr rjrjr approved these changes

@zach-klippenstein zach-klippenstein Awaiting requested review from zach-klippenstein zach-klippenstein is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkwiz @rjrjr