Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendlier construction API for BackStackScreen #1110

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

rjrjr
Copy link
Contributor

@rjrjr rjrjr commented Sep 21, 2023

  • Deprecates the confusing bottom, rest: List constructor with an eye toward making it private
  • Adds fromList and fromListOrNull factory functions to BackStackScreen.Companion, since no one ever finds the List extensions

We'll preserve the bottom, rest: List constructor as the core one because it makes it impossible to build an invalid instance.

@rjrjr
Copy link
Contributor Author

rjrjr commented Sep 21, 2023

Actually…let me update this to have a fundamental private constructor that just takes a list. It'll be more efficient and the public API will still prevent mistakes.

@rjrjr rjrjr force-pushed the ray/buildView-deprecation-tweak branch 3 times, most recently from 8d9522a to ba6caa1 Compare September 21, 2023 14:27
* Deprecates the confusing `bottom: T, rest: List` constructor
* Adds `fromList` and `fromListOrNull` factory functions to `BackStackScreen.Companion`, since no one ever finds the `List` extensions
@rjrjr rjrjr force-pushed the ray/buildView-deprecation-tweak branch from ba6caa1 to 5d385ce Compare September 21, 2023 14:29
@rjrjr rjrjr merged commit fb7001e into main Sep 21, 2023
29 of 31 checks passed
@rjrjr rjrjr deleted the ray/buildView-deprecation-tweak branch September 21, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants