Fixes leak when calling destroyOnDetach from onDetachedFromWindow.
#1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`View.isAttachedToWindow` returns false while the view is dispatching calls to `onDetachedFromWindow`. As a result, calling `WorkflowLifecycleOwner.destroyOnDetach` from an `onDetachedFromWindow` handler that was downstream of its own would mean that the WLO would never get destroyed. Also makes `DialogSession.destroyDialog` idempotent. Necessary because `ComponentDialog.dismiss()` is not, and with this fix we are more likely to call that redundantly. (The actual culprit is `ComponentDialog.onStop()`, which nulls out `ComponentDialog._lifecycleRegistry`. The second call to that method creates a new instance on demand as a side effect to its call to `handleLifecycleEvent`, which immediately throws due to an illegal transition from `INITIALIZED` to `DESTROYED`. Tried to rely on just checking `Dialog.isShowing` before calling `dismiss()`, but that's not reliable.)
rjrjr
force-pushed
the
ray/fix-WorkflowLifecycleOwner-destroyOnDetach-from-onDetach-leak
branch
from
7f2197a to
45f02b7
Compare
steve-the-edwards
approved these changes
Aug 8, 2023
rjrjr
deleted the
ray/fix-WorkflowLifecycleOwner-destroyOnDetach-from-onDetach-leak
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
View.isAttachedToWindowreturns false while the view is dispatching calls toonDetachedFromWindow. As a result, callingWorkflowLifecycleOwner.destroyOnDetachfrom anonDetachedFromWindowhandler that was downstream of its own would mean that the WLO would never get destroyed.Also makes
DialogSession.destroyDialogidempotent. Necessary becauseComponentDialog.dismiss()is not, and with this fix we are more likely to call that redundantly.(The actual culprit is
ComponentDialog.onStop(), which nulls outComponentDialog._lifecycleRegistry. The second call to that method creates a new instance on demand as a side effect to its call tohandleLifecycleEvent, which immediately throws due to an illegal transition fromINITIALIZEDtoDESTROYED. Tried to rely on just checkingDialog.isShowingbefore callingdismiss(), but that's not reliable.)