Update Turbine to 0.13.0 #1035
Update Turbine to 0.13.0 #1035
Conversation
Update Turbine to 0.13.0; Update WorkerTester assertNoOutput now fails if there is a completion of the WOrker's flow.
steve-the-edwards
requested review from
a team and
zach-klippenstein
as code owners
| worker.test { | ||
| assertNoOutput() | ||
| } | ||
| } | ||
|
|
||
| @Test fun `assertNoOutput fails after worker finishes without emitting`() { |
There was a problem hiding this comment.
if worker finishes without emitting anything, then assertNoOutput should succeed right? as the name suggest it should check for no output
There was a problem hiding this comment.
@steve-the-edwards I'm confused by this too.
There was a problem hiding this comment.
Actually, I'm not confused by the test method name, but by the semantic: why is it now an error for a worker to complete when we assertNoOutput()? This change broke some existing tests that were building workers via Observable.just(), for example.
There was a problem hiding this comment.
I think you guys are right I should have made more noise about the change in this semantic. I just took the easy way out and inherited the change from expectNoEvents() when it started throwing on Completion after Turbine 0.3.0.
I've done a quick look and I'm not sure there is good way to reproduce the behavior we had before. @RotBolt could you create an issue to update this or rename the assertion to something like assertNoOutputOrCompletion()?
I think I am ok with having places where we use flowOf { 1 } or Observable.just(false) to start using assertFinished() instead of assertNoOutput(). But maybe that's a cop out?
There was a problem hiding this comment.
It's easy to replace Observable.just(false) with BehaviorRelay.createDefault(false). Is there a similar idiom for Flow?
There was a problem hiding this comment.
flow { emit(false); suspendCancellableCoroutine {} }
so tidy right?
hmm. must be something better
Update Turbine to 0.13.0; Update WorkerTester
assertNoOutput now fails if there is a completion of the WOrker's flow.