Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for windows platform users to manually add file templates to IDE #1032

Merged

Conversation

RotBolt
Copy link
Contributor

@RotBolt RotBolt commented Jun 19, 2023

Hi @rjrjr
Raised one PR to add info for windows platform users

@RotBolt RotBolt requested review from a team and zach-klippenstein as code owners June 19, 2023 06:15
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2023

CLA assistant check
All committers have signed the CLA.

@@ -22,6 +22,12 @@ Let's start by making a workflow and screen to back the welcome view.

Start by creating a new workflow and screen by creating a new file with the [file templates](../../install-templates.sh), adding it to the `tutorial-base` module:

___NOTE___

_The install script would not work for windows platform. For windows user, please add the scripts from [file templates folder](../../fileTemplates) manually to Android Studio or Intellij Idea._
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_The install script would not work for windows platform. For windows user, please add the scripts from [file templates folder](../../fileTemplates) manually to Android Studio or Intellij Idea._
_Windows OS users: Please add the scripts from [file templates folder](../../fileTemplates) directly to Android Studio or Intellij Idea._

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @steve-the-edwards fixed this note wording as suggested


_The install script would not work for windows platform. For windows user, please add the scripts from [file templates folder](../../fileTemplates) manually to Android Studio or Intellij Idea._

_Go to Settings --> Editor --> File and Code Templates --> Select Files Tab. Now click on + icon and copy the workflow file template content to editor and save it_
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_Go to Settings --> Editor --> File and Code Templates --> Select Files Tab. Now click on + icon and copy the workflow file template content to editor and save it_
_Go to Settings --> Editor --> File and Code Templates --> Select Files Tab. Now click on the '+' icon and copy the the content of the Workflow file template to the editor and save it._

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed this note wording as suggested

@RotBolt RotBolt force-pushed the workflow-template-windows-note branch 2 times, most recently from 5ce6f47 to 36b201d Compare June 19, 2023 16:24
@rjrjr rjrjr enabled auto-merge June 20, 2023 17:32
auto-merge was automatically disabled June 20, 2023 17:57

Head branch was pushed to by a user without write access

@RotBolt RotBolt force-pushed the workflow-template-windows-note branch from 36b201d to 095f47a Compare June 20, 2023 17:57
@RotBolt RotBolt force-pushed the workflow-template-windows-note branch from 095f47a to 7ba0242 Compare June 21, 2023 03:13
@steve-the-edwards steve-the-edwards merged commit 5dfb070 into square:main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants