kotlin 1.8.10 and friends #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBusarow
force-pushed
the
rick/kotlin_1.8.10
branch
2 times, most recently
from
e79a755 to
cf744e6
Compare
- kotlin `1.8.10` - ksp `1.8.10-1.0.9` - drop Kotlinter because it doesn't play nicely with KSP's new source sets - replace Kotlinter with `com.rickbusarow.ktlint` - KtLint `0.49.1` - this comes with updated `.editorconfig` requirements
RBusarow
force-pushed
the
rick/kotlin_1.8.10
branch
from
cf744e6 to
5fd4e07
Compare
steve-the-edwards
approved these changes
Jun 13, 2023
| @@ -17,7 +17,7 @@ object HelloBackButtonWorkflow : StatefulWorkflow<Unit, State, Nothing, HelloBac | |||
| enum class State : Parcelable { | |||
| Able, | |||
| Baker, | |||
| Charlie; | |||
| Charlie | |||
There was a problem hiding this comment.
whoa - no more ; at the end. Can we have trailing commas :)?
There was a problem hiding this comment.
This is the standard:no-semi rule. I can enable it if you'd like me to. ;)
For commas... no, it's not possible. It just doesn't work. Lots of performance regressions and all of the internal canary branches crashed.
| @@ -40,7 +40,7 @@ internal class BackStackContainerLifecycleActivity : AbstractLifecycleTestActivi | |||
| context: Context, | |||
| container: ViewGroup? | |||
| ): ScreenViewHolder<BaseRendering> = | |||
| ScreenViewHolder(initialEnvironment, View(context)) { _, _ -> /* Noop */ } | |||
| ScreenViewHolder(initialEnvironment, View(context)) { _, _ -> } | |||
There was a problem hiding this comment.
I don't get these? Did ktlint remove these now?
There was a problem hiding this comment.
For the KtLint 0.49.x season, the comment-wrapping rule doesn't allow for single-line block comments. This is extracted into its own rule for 0.50.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.8.101.8.10-1.0.9com.rickbusarow.ktlint0.49.1.editorconfigrequirements