move convention plugins from buildSrc to an included build-logic project
#1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve-the-edwards
approved these changes
Jun 9, 2023
…project
This decouples the convention plugins' build classpath from the main project's, which makes navigating Gradle/Kotlin/Compose/KSP upgrades a little easier.
Unfortunately, an included build doesn't get the same special treatment during classloading that `buildSrc` does, so convention plugins must be applied via `id("my-convention")` instead of just their name.
RBusarow
force-pushed
the
rick/build-logic_conventions
branch
from
67a7177 to
ec36342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the convention plugins' build classpath from the main project's, which makes navigating Gradle/Kotlin/Compose/KSP upgrades a little easier.
Unfortunately, an included build doesn't get the same special treatment during classloading that
buildSrcdoes, so convention plugins must be applied viaid("my-convention")instead of just their name.