-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alias renderings are too hard to deal with #973
Comments
rjrjr
added a commit
that referenced
this issue
Mar 21, 2023
Coupling `Wrapper` to `ScreenViewFactory.forWrapper` was a mistake, made simple transformations that weren't in the strict `Wrapper` shape more difficult. Fixes #973
rjrjr
added a commit
that referenced
this issue
Mar 21, 2023
Coupling `Wrapper` to `ScreenViewFactory.forWrapper` was a mistake, made simple transformations that weren't in the strict `Wrapper` shape more difficult. Also some compulsive tidying of sample code. Fixes #973
rjrjr
added a commit
that referenced
this issue
Mar 21, 2023
Coupling `Wrapper` to `ScreenViewFactory.forWrapper` was a mistake, made simple transformations that weren't in the strict `Wrapper` shape more difficult. Also some compulsive tidying of sample code. Fixes #973
rjrjr
added a commit
that referenced
this issue
Mar 21, 2023
Coupling `Wrapper` to `ScreenViewFactory.forWrapper` was a mistake, made simple transformations that weren't in the strict `Wrapper` shape more difficult. Also some compulsive tidying of sample code. Fixes #973
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The recent introduction of the
Wrapper
interface (#920) made it easier to create things likeNamedScreen
, where one rendering is used to modify how a wrapped one is displayed; but made it harder to implement "alias" types: custom renderings that are most easily displayed by transforming them into existing types.This is a problem because we encourgage apps to use
BodyAndOverlaysScreen
as a building block to craft their own, stricter rules.e.g., it should be trivial to register a
ScreenViewFactory
that handles this:by transforming it into this:
By coupling the
ScreenViewFactory.forWrapper
to the newWrapper
type, we have actually made that much harder.So, at least two outcomes needed here:
The text was updated successfully, but these errors were encountered: