-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review/audit the ignored ktlint rules #429
Comments
RBusarow
added a commit
that referenced
this issue
Jan 21, 2022
RBusarow
added a commit
that referenced
this issue
Jan 27, 2022
rjrjr
added a commit
that referenced
this issue
Feb 1, 2022
* main: (25 commits) HelloWorkflowFragmentAppTest is no longer suppressed. WorkflowLayout.start needs a Lifecycle, BackStackScreen is supported. Works around square/leakcanary#2297 fix TextInputTest flakes remove unused KAPT from `:workflow-tracing` Use KSP instead of KAPT for Moshi's codegen Update Tutorial kdoc link Update RELEASING instructions and update Tutorial version Finish releasing v1.5.0 Release v1.5.0 apply previously-ignored ktlint rules re-enable ignored ktlint rules and update .editorconfig fixes #429 Launch renderWorkflowIn CoroutineScope with Default; Fixes #643 Update comments in renderWorkflowIn Check if runtime CoroutineScope cancelled after nextOutput() Upgrades leak canary, testing, androidx lifecycle. Finish releasing v1.4.0. Releasing v1.4.0. Introduces WorkflowLayout.update. Updates workflow-testing.api for requireExplicitSideEffectExpectations ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A heads-up just in case you're interested in a follow-on PR:
It looks like the import-ordering issue has been (mostly) fixed thanks to the introduction of a layout table for Kotlin imports. (But note the misbehavior cited at the end of that conversation, including a comment by the tried-and-true Valeriy Ovechkin 😺 .)
Originally posted by @maybeYouShouldBeTheLawyer in #420 (comment)
The text was updated successfully, but these errors were encountered: