Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keep rule for keeping generic signature of return types #3886

Merged
merged 2 commits into from
May 5, 2023
Merged

Add keep rule for keeping generic signature of return types #3886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b325fd
Add keep rule for keeping generic signature of return types
mkj-gram May 2, 2023
83dcbd7
Remove now obsolete shrinker rules
JakeWharton May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions retrofit-adapters/guava/src/main/resources/META-INF/proguard/retrofit2-guava-adapter.pro
View file
Open in desktop

This file was deleted.

3 changes: 0 additions & 3 deletions retrofit-adapters/rxjava/src/main/resources/META-INF/proguard/retrofit2-rxjava-adapter.pro
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions retrofit-adapters/rxjava2/src/main/resources/META-INF/proguard/retrofit2-rxjava2-adapter.pro
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions retrofit-adapters/rxjava3/src/main/resources/META-INF/proguard/retrofit2-rxjava3-adapter.pro
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions retrofit/src/main/resources/META-INF/proguard/retrofit2.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
-if interface * { @retrofit2.http.* <methods>; }
-keep,allowobfuscation interface * extends <1>

# Keep generic signature of Call, Response (R8 full mode strips signatures from non-kept items).
-keep,allowobfuscation,allowshrinking interface retrofit2.Call
-keep,allowobfuscation,allowshrinking class retrofit2.Response

# With R8 full mode generic signatures are stripped for classes that are not
# kept. Suspend functions are wrapped in continuations where the type argument
# is used.
-keep,allowobfuscation,allowshrinking class kotlin.coroutines.Continuation

# R8 full mode strips generic signatures from return types if not kept.
-if interface * { @retrofit2.http.* public *** *(...); }
-keep,allowoptimization,allowshrinking,allowobfuscation class <3>