Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable built-in Optional converter on Android API 24+ #2960

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

JakeWharton
Copy link
Collaborator

No description provided.

@JakeWharton JakeWharton force-pushed the jakew/optional-android/2018-11-16 branch from d817ef3 to 4473565 Compare November 16, 2018 20:17
@JakeWharton JakeWharton force-pushed the jakew/optional-android/2018-11-16 branch from 4473565 to 4f93cd8 Compare November 16, 2018 20:18
* converter to deserialize {@code T} and then wraps it into {@link Optional}.
*/
@IgnoreJRERequirement
@IgnoreJRERequirement // Only added when Optional is available (Java 8+ / Android API 24+).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

service = retrofit.create(Service.class);
}

@Config(sdk = 24)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@swankjesse swankjesse merged commit 6e2643f into master Nov 16, 2018
@JakeWharton JakeWharton deleted the jakew/optional-android/2018-11-16 branch November 18, 2018 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants