Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use support library's ExifInterface. #1748

Merged

Conversation

NightlyNexus
Copy link
Contributor

@NightlyNexus NightlyNexus commented Feb 28, 2018

100% didn't test this.
cmd+shift+R and the tests passed.

junit : 'junit:junit:4.12',
truth : 'com.google.truth:truth:0.36',
robolectric : 'org.robolectric:robolectric:3.1',
mockito : 'org.mockito:mockito-core:1.9.5'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who thought column alignment was a good idea 🤦‍♂️

(Don't let it be me... don't let it be me...)

@JakeWharton JakeWharton merged commit 359710d into square:master Feb 28, 2018
@NightlyNexus
Copy link
Contributor Author

manually checked and it works fine.
also, there are big tests for this!

@NightlyNexus NightlyNexus deleted the eric.2018-02-28.exifinterface branch March 1, 2018 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants