Fix incorrect cache size reporting after Bitmap is recycled. #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oof |
JakeWharton
reviewed
Jan 10, 2018
| @@ -17,6 +17,7 @@ | |||
| package com.squareup.picasso; | |||
|
|
|||
| import android.graphics.Bitmap; | |||
| import android.util.Pair; | |||
JakeWharton
approved these changes
Jan 10, 2018
Previously, if a user called recycle on a Bitmap in the cache, the allocation size would not be subtracted correctly (on SDK 25+) when the Bitmap was evicted from the cache.
NightlyNexus
force-pushed
the
eric.20170110.bitmap-recycled-in-cache
branch
from
0c219d0 to
4c80c43
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a user called recycle on a Bitmap in the cache, the allocation size would not be subtracted correctly (on SDK 25+) when the Bitmap was evicted from the cache.
I'm not sure that anyone should ever call recycle on a Bitmap in the cache, but it'd be difficult to communicate the error.
Closes #1693