Accommodate tunneling proxies that close the connection after an auth challenge. #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // The proxy decided to close the connection after an auth challenge. We need to create a new | ||
| // connection, but this time with the auth credentials. | ||
| closeQuietly(rawSocket); |
There was a problem hiding this comment.
nit: also set rawSocket to null?
|
LGTM This is brilliant. Very nice. |
dave-r12
force-pushed
the
dr-Apr072016-tunnel-proxy-close
branch
from
a7a9c73 to
03a840d
Compare
|
@dave-r12 / @swankjesse : Many thanks to you guys 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #2426. This was mainly a rejiggering of the existing connection code.