Lazily enable the Android components #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeapAnalyzerService, AnalysisResultService and DisplayLeakActivity are all disabled by default. They're now enabled only as needed. This means they won't be enabled when LeakCanary is used in CI, or when there are no leak.
kurtisnelson
approved these changes
Jun 16, 2018
| @@ -83,6 +84,7 @@ public static PendingIntent createPendingIntent(Context context) { | |||
| } | |||
|
|
|||
| public static PendingIntent createPendingIntent(Context context, String referenceKey) { | |||
| setEnabledBlocking(context, DisplayLeakActivity.class, true); | |||
There was a problem hiding this comment.
Doesn't this now block for a non-zero amount of time on every leak?
There was a problem hiding this comment.
Yep, but from an IntentService handler thread so 🤷♂️
| @@ -53,17 +53,12 @@ | |||
| public static final String HUAWEI = "HUAWEI"; | |||
| public static final String VIVO = "vivo"; | |||
|
|
|||
| private static final Executor fileIoExecutor = newSingleThreadExecutor("File-IO"); | |||
There was a problem hiding this comment.
I'm excited when people are excited! I'd love to know why you're excited though :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeapAnalyzerService, AnalysisResultService and DisplayLeakActivity are all disabled by default. They're now enabled only as needed.
This means they won't be enabled when LeakCanary is used in CI, or when there are no leak.