Moving LeakDirectoryProvider to LeakCanaryInternals #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On top of the AndroidHeapDumper, we also need to access LeakDirectoryProvider from DisplayLeakActivity. We'll soon need to also access it from the UI test run listener. We can't keep the instance as a field of the RefWatcher singleton because DisplayLeakActivity lives in a different process. This change renames LeakCanary.setDisplayLeakActivityDirectoryProvider to LeakCanary.setLeakDirectoryProvider and makes sure we use that global LeakDirectoryProvider everywhere.
kurtisnelson
approved these changes
Jun 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of the AndroidHeapDumper, we also need to access LeakDirectoryProvider from DisplayLeakActivity. We'll soon need to also access it from the UI test run listener. We can't keep the instance as a field of the RefWatcher singleton because DisplayLeakActivity lives in a different process.
This change renames LeakCanary.setDisplayLeakActivityDirectoryProvider to LeakCanary.setLeakDirectoryProvider and makes sure we use that global LeakDirectoryProvider everywhere.