You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
My team tried to update Leak Canary to the latest version (1.6.2) and we noticed that this change (#1117) modified significantly how Leak Canary works in our builds.
To give you more context, our app defines an internal production flavor that gets distributed only for employees. In this internal production app we can enable/disable certain configuration flags, being one of them memory leaks detections. If the user enables memory leaks detection, any memory leak detected gets uploaded to our logging or crash report system, as explained in the Wiki here. Instead of extending from the DisplayLeakService, we extend from AbstractAnalysisResultService, which allow us to report the analysis results without the need of displaying the leak activity or installing the side LeakCanary app. This way employees see the ForegroundService notification when the memory is being dumped and analyzed but don't see an unknown application named Leaks mysteriously installed on their phone.
In addition, we also noticed that some of our Instrumentation tests were suddenly failing because of this new requirement of the library.
We believe it would be great to have an option to disable this requirement as you suggested in the description of the issue #1115. I hope this use case makes sense to you and has enough value to consider it. We are also opened to alternative solutions. Thanks in advance.
Cheers.
The text was updated successfully, but these errors were encountered:
Hi @pyricau !
My team tried to update Leak Canary to the latest version (
1.6.2
) and we noticed that this change (#1117) modified significantly how Leak Canary works in our builds.To give you more context, our app defines an internal production flavor that gets distributed only for employees. In this internal production app we can enable/disable certain configuration flags, being one of them memory leaks detections. If the user enables memory leaks detection, any memory leak detected gets uploaded to our logging or crash report system, as explained in the Wiki here. Instead of extending from the
DisplayLeakService
, we extend fromAbstractAnalysisResultService
, which allow us to report the analysis results without the need of displaying the leak activity or installing the side LeakCanary app. This way employees see the ForegroundService notification when the memory is being dumped and analyzed but don't see an unknown application namedLeaks
mysteriously installed on their phone.In addition, we also noticed that some of our Instrumentation tests were suddenly failing because of this new requirement of the library.
We believe it would be great to have an option to disable this requirement as you suggested in the description of the issue #1115. I hope this use case makes sense to you and has enough value to consider it. We are also opened to alternative solutions. Thanks in advance.
Cheers.
The text was updated successfully, but these errors were encountered: