Support the explicit API mode when generating Dagger factories #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e explicit API mode by default.
marcellogalhardo
force-pushed
the
main
branch
from
de97c8f to
03d2f84
Compare
|
Updated the PR to use KotlinPoet 1.7.2. |
vRallev
requested changes
Oct 25, 2020
There was a problem hiding this comment.
I'm so sorry for the delay. This PR is great. Could I ask you to enable the explicit API mode in the :integration-tests:* module rather than the sample? The sample is supposed to be closer to the real world and many projects won't enable the explicit API mode. On the other side, that's exactly the purpose of the integration tests.
marcellogalhardo
force-pushed
the
main
branch
2 times, most recently
from
98e459e to
0207aa1
Compare
|
Hey @vRallev - no worries, I understand. I dropped the changes on |
added 2 commits
October 26, 2020 08:53
marcellogalhardo
force-pushed
the
main
branch
from
0207aa1 to
575cba7
Compare
vRallev
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anvil uses KotlinPoet to generate the Dagger factories in which in the latest version 1.7.0: "Generated code is now compatible with the explicit API mode by default.".
This PR:
1.7.0with Java 8.:sample:scopesand:sample:librarymodules to show its usage,:sample:appmodule is untouched as it is not a "library" module. If this is not necessary, I can revert the commit.Fixes #144.