Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix tap gesture swallowing touches in swipe actions view #528

Merged
merged 1 commit into from
Feb 28, 2024
Merged

fix: Fix tap gesture swallowing touches in swipe actions view #528

merged 1 commit into from
Feb 28, 2024

Conversation

nsillik
Copy link
Collaborator

@nsillik nsillik commented Feb 28, 2024 •
edited
Loading

There were cases in which the item ItemCell.ContentViewContainer's UITapGestureRecognizer was swallowing touches over some of the swipe action buttons. This fixes it by only allowing the gesture recognizer to begin when the touches are inside of the contentView.

Checklist

Please do the following before merging:

  • Ensure any public-facing changes are reflected in the changelog. Include them in the Main section.

@nsillik
Copy link
Collaborator Author

nsillik commented Feb 28, 2024 •
edited
Loading

  • wait until integration passes

@nsillik
Copy link
Collaborator Author

nsillik commented Feb 28, 2024

well, it didn't pass, but it was just squinter, good to go

@nsillik nsillik merged commit e9401c3 into main Feb 28, 2024
4 checks passed
@nsillik nsillik deleted the @nsillik/swiping-fix branch February 28, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsocik1 adamsocik1 adamsocik1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nsillik @adamsocik1