Fix Reordering Crash #308
Merged
Fix Reordering Crash #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleve
force-pushed
the
kve/fix-checkout-reorder-crashes
branch
2 times, most recently
from
94651b9 to
b4a13ce
Compare
…ates after the edit do not cause crashes within UICollectionView; it does not account for mutations while a reorder is settling.
kyleve
force-pushed
the
kve/fix-checkout-reorder-crashes
branch
from
b4a13ce to
1a71aa9
Compare
kyleve
force-pushed
the
kve/fix-checkout-reorder-crashes
branch
from
49056c0 to
bcab467
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a queue that we can stop during re-order events; to prevent the case that a row is removed as the result of signalling to listeners that a re-order happened – which the collection view doesn't does not internally handle.