Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse contentInset values when updating for keyboard to ensure we don't clobber other values. #267

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Reuse contentInset values when updating for keyboard to ensure we don't clobber other values. #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

### Fixed

- [When updating `contentInset`, retain the values pulled from the `CollectionView`](https://github.com/kyleve/Listable/pull/267). This is to avoid clobbering the content inset potentially set by other things like navigation controllers.

### Added

### Removed
Expand Down
9 changes: 3 additions & 6 deletions ListableUI/Sources/ListView/ListView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,12 +325,9 @@ public final class ListView : UIView, KeyboardObserverDelegate
$0.bottom = max($0.bottom, keyboardBottomInset)
}

let contentInsets = UIEdgeInsets(
top: 0,
left: 0,
bottom: keyboardBottomInset,
right: 0
)
let contentInsets = modified(self.collectionView.contentInset) {
$0.bottom = keyboardBottomInset
}

return (contentInsets, scrollIndicatorInsets)
}
Expand Down