Fix content inset issues with scroll indicators and keyboard insets #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any idea if this also resolves #85 ? |
|
It's not super clear to me what the issue was for #85, what's the incorrect behavior on <= iOS 10? |
kyleve
approved these changes
Mar 6, 2020
On iOS 10, the scroll view sets the contentInset for tab bar or nav bar insets – because iOS 7+ underflowed those controls, but safe area wasnt a thing until iOS 11. Reading this, I dont think this makes it any better or worse, so, yay |
|
Also, I never even knew |
|
Yah, I dunno why it’s not just automatically set TBH. Nice detail to fix though, always bugs me when apps with custom headers and stuff don’t (Spotify comes to mind)
… On Mar 6, 2020, at 10:30 AM, Kyle Van Essen ***@***.***> wrote:
Also, I never even knew scrollIndicatorInsets was a thing. TIL!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#103>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA25A7YYMQKLP736AW2MMP3RGE6LRANCNFSM4LDFLC6Q>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the scroll indicator insets not being set to match the content insets, which is almost always the correct behavior. In the first GIF you can see the scroll indicator disappears behind the keyboard, while the in the second gif it matches the content size.
This PR also fixes an issue when calculating the inset to add to adjust for a visible keyboard. I chose to subtract the bottom content inset from the calculation, as the collection view keeps the safe area inset in addition to insets you set. Another option might be to disable safe area inset adjustments entirely, but then we would lose the automatic adjustment when in most cases we want it. In the first GIF you can see the gap between the collection view content and the keyboard. In the second, there's no gap. Both have the correct safe area when the keyboard is not visible.