Skip to content

Commit

Permalink
Reuse contentInset values when updating for keyboard to ensure we don…
Browse files Browse the repository at this point in the history
…'t clobber other values.
  • Loading branch information
kyleve committed Feb 10, 2021
1 parent 4ad8474 commit 7e21b08
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

### Fixed

- [When updating `contentInset`, retain the values pulled from the `CollectionView`](TODO). This is to avoid clobbering the content inset potentially set by other things like navigation controllers.

### Added

### Removed
Expand Down
9 changes: 3 additions & 6 deletions ListableUI/Sources/ListView/ListView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -325,12 +325,9 @@ public final class ListView : UIView, KeyboardObserverDelegate
$0.bottom = max($0.bottom, keyboardBottomInset)
}

let contentInsets = UIEdgeInsets(
top: 0,
left: 0,
bottom: keyboardBottomInset,
right: 0
)
let contentInsets = modified(self.collectionView.contentInset) {
$0.bottom = keyboardBottomInset
}

return (contentInsets, scrollIndicatorInsets)
}
Expand Down

0 comments on commit 7e21b08

Please sign in to comment.