Xcode 11 build fixes

square · Dec 1, 2020 · 72d32c6 · 72d32c6
1 parent b149414
commit 72d32c6
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 23 deletions.
diff --git a/BlueprintUILists.podspec b/BlueprintUILists.podspec
@@ -1,7 +1,7 @@
 
 Pod::Spec.new do |s|
   s.name         = 'BlueprintUILists'
-  s.version      = '0.12.0'
+  s.version      = '0.12.1'
   s.summary      = 'Declarative list views for iOS apps that deploy back to iOS 11.0.'
   s.homepage     = 'https://github.com/kyleve/Listable'
   s.license      = 'Apache License, Version 2.0'

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,12 @@
 
 # Past Releases
 
+# [0.12.1] - 2020-12-01
+
+### Fixed
+
+- [Fixed frame setting calcuations, and fixed building in Xcode 11](https://github.com/kyleve/Listable/pull/234).
+
 # [0.12.0] - 2020-12-01
 
 ### Fixed

diff --git a/Demo/Sources/Demos/Demo Screens/AutoScrollingViewController.swift b/Demo/Sources/Demos/Demo Screens/AutoScrollingViewController.swift
@@ -70,17 +70,19 @@ final class AutoScrollingViewController : UIViewController
                     .lastItem,
                     onInsertOf: last.identifier,
                     position: .init(position: .bottom),
-                    animation: .default
-                ) { info in
-                    // Only scroll to the bottom if the bottom item is already visible.
-                    if let identifier = lastItem {
-                        return info.visibleItems.contains(identifier)
-                    } else {
-                        return false
+                    animation: .default,
+                    shouldPerform: { info in
+                        // Only scroll to the bottom if the bottom item is already visible.
+                        if let identifier = lastItem {
+                            return info.visibleItems.contains(identifier)
+                        } else {
+                            return false
+                        }
+                    },
+                    didPerform: { info in
+                        print("Did scroll: \(info)")
                     }
-                } didPerform: { info in
-                    print("Did scroll: \(info)")
-                }
+                )
             }
 
             let itemization = [

diff --git a/ListableUI.podspec b/ListableUI.podspec
@@ -1,7 +1,7 @@
 
 Pod::Spec.new do |s|
   s.name         = 'ListableUI'
-  s.version      = '0.12.0'
+  s.version      = '0.12.1'
   s.summary      = 'Declarative list views for iOS apps that deploy back to iOS 11.0.'
   s.homepage     = 'https://github.com/kyleve/Listable'
   s.license      = 'Apache License, Version 2.0'

diff --git a/ListableUI/Sources/ScrollAnimation.swift b/ListableUI/Sources/ScrollAnimation.swift
@@ -47,11 +47,17 @@ public enum ScrollAnimation {
             )
 
         case .custom(let duration, let options):
-            UIView.animate(withDuration: duration, delay: 0.0, options: options.toSystem) {
-                animations()
-            } completion: { finished in
-                completion(finished)
-            }
+            UIView.animate(
+                withDuration: duration,
+                delay: 0.0,
+                options: options.toSystem,
+                animations: {
+                    animations()
+                },
+                completion: { finished in
+                    completion(finished)
+                }
+            )
 
         case .spring(let duration, let timing):
             let animator = UIViewPropertyAnimator(duration: duration, timingParameters: timing)

diff --git a/Podfile.lock b/Podfile.lock
@@ -2,15 +2,15 @@ PODS:
   - BlueprintUI (0.16.0)
   - BlueprintUICommonControls (0.16.0):
     - BlueprintUI
-  - BlueprintUILists (0.12.0):
+  - BlueprintUILists (0.12.1):
     - BlueprintUI
     - ListableUI
-  - BlueprintUILists/Tests (0.12.0):
+  - BlueprintUILists/Tests (0.12.1):
     - BlueprintUI
     - ListableUI
   - EnglishDictionary (1.0.0.LOCAL)
-  - ListableUI (0.12.0)
-  - ListableUI/Tests (0.12.0):
+  - ListableUI (0.12.1)
+  - ListableUI/Tests (0.12.1):
     - EnglishDictionary
     - Snapshot
   - Snapshot (1.0.0.LOCAL)
@@ -45,9 +45,9 @@ EXTERNAL SOURCES:
 SPEC CHECKSUMS:
   BlueprintUI: 5c667416346644e2199c441ff5f1288bd8890a04
   BlueprintUICommonControls: 700e23030617ffc3a62621cb875cd9965a2292b3
-  BlueprintUILists: 788a5495104f6a3e14439bff27254fcbfc3993a7
+  BlueprintUILists: 2276fa7c17060d6e99fb36a5d42006d4260a698f
   EnglishDictionary: f03968b9382ddc5c8dd63535efbf783c6cd45f1c
-  ListableUI: 31a4273f0efe901510d67511d843b5c50a5fb066
+  ListableUI: 8c37883f7ea0c62c5fb254f8f55c1334546cfed9
   Snapshot: cda3414db426919d09f775434b36289c8e864183
 
 PODFILE CHECKSUM: c1209f66d9213201c70fd26a2f0907a6e29e8cbe