AttributedLabel Link Accessibility #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyalPineapple
force-pushed
the
alex/LinkAccessibility
branch
from
8a97a0e to
0344a7f
Compare
RoyalPineapple
force-pushed
the
alex/LinkAccessibility
branch
2 times, most recently
from
bc23c22 to
e6457d0
Compare
RoyalPineapple
commented
Jun 29, 2023
RoyalPineapple
commented
Jun 29, 2023
kyleve
reviewed
Jun 29, 2023
kyleve
reviewed
Jun 29, 2023
BlueprintUI/Sources/Environment/Keys/AccessibilityLinkKey.swift
Outdated
Show resolved
Hide resolved
kyleve
reviewed
Jun 29, 2023
RoyalPineapple
force-pushed
the
alex/LinkAccessibility
branch
from
0859d99 to
bf6ac37
Compare
RoyalPineapple
force-pushed
the
alex/LinkAccessibility
branch
from
bf6ac37 to
cff4341
Compare
|
It looks like there's some failing tests: |
kyleve
reviewed
Nov 29, 2023
kyleve
reviewed
Nov 29, 2023
kyleve
reviewed
Nov 29, 2023
RoyalPineapple
force-pushed
the
alex/LinkAccessibility
branch
2 times, most recently
from
ec73157 to
736cd9e
Compare
RoyalPineapple
force-pushed
the
alex/LinkAccessibility
branch
from
736cd9e to
b8acc6f
Compare
RoyalPineapple
force-pushed
the
alex/LinkAccessibility
branch
4 times, most recently
from
7bfd79a to
88a7dca
Compare
kyleve
approved these changes
Nov 30, 2023
|
|
RoyalPineapple
force-pushed
the
alex/LinkAccessibility
branch
from
aa9b363 to
d12564c
Compare
|
@RoyalPineapple Moving to draft because I think this was addressed elsewhere but feel free to reopen if needed! |
meherkasam-square
approved these changes
May 30, 2024
…f the .link string attribute which we strip to allow our own styling
RoyalPineapple
force-pushed
the
alex/LinkAccessibility
branch
from
d12564c to
599f360
Compare
RoyalPineapple
force-pushed
the
alex/LinkAccessibility
branch
from
e20a350 to
d62afc3
Compare
RoyalPineapple
added a commit
that referenced
this pull request
Jun 13, 2024
Bump to 4.1.0 to include new link accessibility fixes #459
maxg-square
added a commit
that referenced
this pull request
Nov 4, 2024
* tag '4.3.0': Prepare version 4.3.0 (#513) Add passThroughTouches to BlueprintView, PassthroughView (#511) Bump checkout and upload-artifacts (#512) Bump rexml from 3.2.8 to 3.3.6 Unnest Box.CornerStyle (#508) Prepare 4.2.1 (#507) Make public the UIBezierPath helper using Box.CornerStyle Prepare 4.2.0 (#505) Label and AttributedLabel now support accessibilityValue (#504) Prepare 4.1.2 Release (#503) Replace newlines in a11y labels with spaces (#502) Fix string index out of bounds crash. (#501) bumping version to 4.1.0 (#499) AttributedLabel Link Accessibility (#459)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating attributed label's links to more closely mirror the SwiftUI accessibility experience
SwiftUI.Link.mp4
This is our current implementation, which doesn't announce links properly.
WithoutLinks.mov
Here is the new version, announcing links as they are read.
WithLinks.mp4