Xcode 14 #432
Merged
Xcode 14 #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watt
commented
Feb 23, 2023
|
|
||
| strategy: | ||
| fail-fast: false # Don’t fail-fast so that we get all snapshot test changes | ||
| matrix: | ||
| include: | ||
| - sdk: "14.5" | ||
| destination: platform=iOS Simulator,OS=14.5,name=iPhone 8 | ||
| destination: platform=iOS Simulator,OS=14.5,name=iPad (8th generation) |
There was a problem hiding this comment.
Installing iOS 14.5 with xcodes doesn't create an iPhone 8 sim for some reason, so I just picked another 2x device.
watt
commented
Feb 23, 2023
| @@ -43,7 +47,7 @@ jobs: | |||
| - name: Package snapshot changes | |||
| if: ${{ failure() }} | |||
| run: | | |||
| git ls-files -mo BlueprintUICommonControls/Tests/Sources/ReferenceImages | xargs tar -cvf snapshot_changes_${{ matrix.sdk }}.tar | |||
| git ls-files -mo BlueprintUICommonControls/Tests/Sources/Resources/ReferenceImages | xargs tar -cvf snapshot_changes_${{ matrix.sdk }}.tar | |||
There was a problem hiding this comment.
This fixes the link to download failed snapshot test images.
watt
commented
Feb 23, 2023
| @@ -0,0 +1,143 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <Scheme | |||
There was a problem hiding this comment.
I committed these schemes to work around a bug in Xcode 14. More details linked from the comment in the gitignore file.
watt
commented
Feb 23, 2023
| @@ -24,7 +24,7 @@ class PerformancePlayground: XCTestCase { | |||
|
|
|||
| override func invokeTest() { | |||
| // Uncomment this line to run performance metrics, eg in Instruments.app. | |||
| super.invokeTest() | |||
| // super.invokeTest() | |||
There was a problem hiding this comment.
I think this was previously committed accidentally. Disabled again to make the tests run faster.
kyleve
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Blueprint to build on Xcode 14 and Swift 5.7. It's mostly CI config.
Updating SwiftFormat picked up a few new linting changes.
xcversionis being sunset and does not support Xcode 14. Replaced it with xcodes.There's a new entry in the snapshot test matrix for iOS 16.2. Also deleted the images from iOS 13 & 14 which are now unused.