Self review 2

Internal/KeyboardObserver.swift → BlueprintUICommonControls/Sources/Internal/KeyboardObserver.swift

@@ -69,17 +69,25 @@ final class KeyboardObserver
         }
     }
 
-    private func animate(with info : NotificationInfo, _ block : @escaping () -> ())
+    private func animate(with info : NotificationInfo, _ animations : @escaping () -> ())
     {
         if info.animationDuration > 0.0 {
+            /**
+             Create an animation curve with the correct curve for showing or hiding the keyboard.
+
+             This is unfortunately a private UIView curve. However, we can map it to the animation options' curve
+             like so: https://stackoverflow.com/questions/26939105/keyboard-animation-curve-as-int
+             */
+            let animationOptions = UIView.AnimationOptions(rawValue: info.animationCurve << 16)
+
             UIView.animate(
                 withDuration: info.animationDuration,
                 delay: 0.0,
-                options: .init(rawValue: info.animationCurve << 16),
-                animations: block
+                options: animationOptions,
+                animations: animations
             )
         } else {
-            block()
+            animations()
         }
     }
 
@@ -110,16 +118,12 @@ final class KeyboardObserver
 
     @objc func keyboardFrameChanged(_ notification : Notification)
     {
-        let info : NotificationInfo
-
         do {
-            info = try NotificationInfo(with: notification)
+            let info = try NotificationInfo(with: notification)
+            self.receivedUpdatedKeyboardInfo(info)
         } catch {
             assertionFailure("Blueprint could not read system keyboard notification. This error needs to be fixed in Blueprint. Error: \(error)")
-            return
         }
-
-        self.receivedUpdatedKeyboardInfo(info)
     }
 }
 

BlueprintUICommonControls/Tests/Sources/Internal/KeyboardObserverTests.swift

@@ -1,10 +1,3 @@
-//
-//  KeyboardObserverTests.swift
-//  Listable-Unit-Tests
-//
-//  Created by Kyle Van Essen on 11/22/19.
-//
-
 import XCTest
 import UIKit
 

SampleApp/Podfile

@@ -1,6 +1,4 @@
 platform :ios, '12.0'
-inhibit_all_warnings!
-use_frameworks!
 
 project 'SampleApp.xcodeproj'
 

SampleApp/Podfile.lock

@@ -22,6 +22,6 @@ SPEC CHECKSUMS:
   BlueprintUI: e5f89d442f225e1865aa8f153dc9da3f1adcbfc4
   BlueprintUICommonControls: 081862011936eaad26f8d606803fa9539ce188ab
 
-PODFILE CHECKSUM: 5490b44dd22c31a1927df648f14fa88cce462867
+PODFILE CHECKSUM: 1e8513f2ddc9f8511335f2c2c2378c4da8250058
 
 COCOAPODS: 1.8.4