Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release typedoc error #168

Merged
merged 5 commits into from
Dec 9, 2024
Merged

fix release typedoc error #168

merged 5 commits into from
Dec 9, 2024

Conversation

Gioee
Copy link
Member

@Gioee Gioee commented Dec 9, 2024

Description of change

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@danielebriggi in the last pr I forgot to test typedoc, now it works locally. So the release workflow should start to work again. I've re-added the typedoc markdown dependency since it was used by typedoc. I've also updated some dependencies.
I've also deleted the pr.yml workflow since it wasn't used and was redundant to the test workflow we worked on last week.

@Gioee Gioee added bug Something isn't working dependencies Pull requests that update a dependency file labels Dec 9, 2024
@Gioee Gioee requested a review from danielebriggi December 9, 2024 10:10
@Gioee Gioee self-assigned this Dec 9, 2024
@Gioee Gioee merged commit 33cfaa6 into main Dec 9, 2024
17 of 22 checks passed
@danielebriggi danielebriggi deleted the fix-typescript-fail-workflow branch December 9, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants