Fix issue with file matching and linting invalid files

src/features/linter.ts

@@ -20,7 +20,7 @@ export default class LinterProvider implements Linter {
     return provider;
   }
 
-  public process(lines: string[]): FileDiagnostic[] {
+  public process(lines: string[], documentPath: string): FileDiagnostic[] {
     const editor = vscode.window.activeTextEditor;
     const diagnostics: FileDiagnostic[] = [];
 
@@ -51,7 +51,7 @@ export default class LinterProvider implements Linter {
 
             if (editor) {
               const editorPath = Utilities.normalizePath(editor.document.fileName);
-              if (editorPath.includes(path) || path === "stdin") {
+              if (editorPath.includes(documentPath) || path === "stdin") {
                 range = editor.document.getWordRangeAtPosition(violationPosition) || range;
               }
             }

src/features/providers/formatter/format.ts

@@ -17,6 +17,10 @@ export class FormattingProvider {
     const workingDirectory = Configuration.workingDirectory(rootPath);
     const textEdits: vscode.TextEdit[] = [];
 
+    if (workingDirectory?.includes("${")) {
+      return [];
+    }
+
     Utilities.appendHyphenatedLine();
     Utilities.outputChannel.appendLine(`Format triggered for ${filePath}`);
 

src/features/providers/linter/lint.ts

@@ -122,6 +122,10 @@ export default class LintingProvider {
       return;
     }
 
+    if (workingDirectory?.includes("${")) {
+      return;
+    }
+
     const args: string[] = [...Configuration.lintFileArguments()];
     const options: CommandOptions = { filePath: filePath };
 
@@ -149,21 +153,23 @@ export default class LintingProvider {
 
     let fileDiagnostics: FileDiagnostic[] = [];
     if (result.lines?.length > 0) {
-      fileDiagnostics = this.linter.process(result.lines);
+      fileDiagnostics = this.linter.process(result.lines, filePath);
+
       if (fileDiagnostics.length === 0 && document) {
         this.diagnosticCollection.set(document.uri, []);
         return;
       }
 
       fileDiagnostics.forEach(async (fileDiagnostic) => {
+        const filePath = document ? Utilities.normalizePath(document.fileName) : undefined;
+
         try {
           if (document && fileDiagnostic.filePath === "stdin") {
             this.diagnosticCollection.set(document.uri, fileDiagnostic.diagnostics);
             return;
           }
-          const fileGlob = "**/" + fileDiagnostic.filePath;
-          const files = await vscode.workspace.findFiles(fileGlob, undefined, 1);
-          const file = files.length > 0 ? files[0].fsPath : Utilities.normalizePath(fileDiagnostic.filePath);
+
+          const file = filePath ? filePath : Utilities.normalizePath(fileDiagnostic.filePath);
           if (file) {
             const uri = vscode.Uri.file(file);
             this.diagnosticCollection.set(uri, fileDiagnostic.diagnostics);

src/features/providers/linter/types/linter.ts

@@ -2,5 +2,5 @@ import FileDiagnostic from "./fileDiagnostic";
 
 export default interface Linter {
   languageId: Array<string>,
-  process: (output: string[]) => FileDiagnostic[];
+  process: (lines: string[], filePath: string) => FileDiagnostic[];
 }

test/.sqlfluff

@@ -1,8 +1,8 @@
 [sqlfluff]
 dialect = postgres
 
-[sqlfluff:rules:L010]
+[sqlfluff:rules:capitalisation.keywords]
 capitalisation_policy = upper
 
-[sqlfluff:rules:L014]
+[sqlfluff:rules:capitalisation.identifiers]
 extended_capitalisation_policy = lower

test/target/suite/test_sql/bad.sql

@@ -0,0 +1 @@
+SELECT a from a_table;