Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react-ace to ^9.4.4 #683

Merged

Conversation

tomch3ng
Copy link
Contributor

@tomch3ng tomch3ng commented Oct 13, 2021

Upgraded react-ace to 9.4.4 (latest) to fix issue where one cannot edit query after execution without clicking outside the query pane first.

Closes #536
Fixes #646

@MasterOdin
Copy link
Member

Could you merge the latest commit to master? That should fix the CI for you.

@MasterOdin MasterOdin changed the title Fix for issue #646 - Upgrade react-ace to latest (9.4.4) Upgrade react-ace to latest (9.4.4) Jan 31, 2022
@MasterOdin MasterOdin force-pushed the fix-646-edit-after-query-execution branch from b953ae4 to 95cfccd Compare January 31, 2022 04:14
@MasterOdin MasterOdin changed the title Upgrade react-ace to latest (9.4.4) Upgrade react-ace to ^9.4.4 Jan 31, 2022
@MasterOdin MasterOdin merged commit 930d545 into sqlectron:main Jan 31, 2022
@MasterOdin
Copy link
Member

Thanks

@tomch3ng tomch3ng deleted the fix-646-edit-after-query-execution branch March 14, 2022 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't input text on editor after a query without clicking discard Upgrade react-ace to ^9
2 participants