Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update core dependencies for 5.4.0 #19978

Merged
merged 7 commits into from
Nov 4, 2022
Merged

PR: Update core dependencies for 5.4.0 #19978

merged 7 commits into from
Nov 4, 2022

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Nov 3, 2022 •
edited
Loading

Description of Changes

  • Missing updates to core dependencies and subrepos
    • spyder-kernels >=2.4.0; <2.5.0
    • qtconsole >=5.4.0; 5.5.0
    • python-lsp-server >=1.6.0; <1.7.0
  • Update RELEASE.md instructions (spyder-kernels max/min version plugin constants location)
  • Remove manual installation of docstring-to-markdown on CI and MacOS standalone installer (py2app based)

Issue(s) Resolved

Fixes #19893

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: dalthviz

@dalthviz
Update core dependencies
86ad7a2
@dalthviz
git subrepo pull (merge) external-deps/spyder-kernels
b2fcc54 
subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "2d1d9aea5"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "2.x"
  commit:   "747299912"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
@dalthviz dalthviz added this to the v5.4.0 milestone Nov 3, 2022
@dalthviz dalthviz requested a review from ccordoba12 November 3, 2022 18:28
@dalthviz dalthviz self-assigned this Nov 3, 2022
@dalthviz
Copy link
Member Author

dalthviz commented Nov 3, 2022

Note: Seems like the test are failing due to conda-forge dropping support for Python 3.7. The new spyder-kernels version is not available on conda-forge for Python 3.7. I think this doesn't affect qtconsole or python-lsp-server since they are no-arch packages. See https://conda-forge.org/docs/user/announcements.html#dropping-python-3-7

@dalthviz
git subrepo pull external-deps/qtconsole
d6bfd2a 
subrepo:
  subdir:   "external-deps/qtconsole"
  merged:   "90ffe335c"
upstream:
  origin:   "https://github.com/jupyter/qtconsole.git"
  branch:   "master"
  commit:   "90ffe335c"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
@dalthviz
Update core dependencies on main.yml
449edb2
@dalthviz
CI: Remove Python 3.7 jobs
3e39496
@dalthviz dalthviz force-pushed the update-core-deps-540 branch 6 times, most recently from 0b586de to c7469e5 Compare November 4, 2022 00:43
@dalthviz dalthviz force-pushed the update-core-deps-540 branch from c7469e5 to 619bb0e Compare November 4, 2022 00:43
@dalthviz
git subrepo pull --branch=v1.6.0 external-deps/python-lsp-server
d135d61 
subrepo:
  subdir:   "external-deps/python-lsp-server"
  merged:   "0c76a528c"
upstream:
  origin:   "https://github.com/python-lsp/python-lsp-server.git"
  branch:   "v1.6.0"
  commit:   "0c76a528c"
git-subrepo:
  version:  "0.4.3"
  origin:   "???"
  commit:   "???"
ccordoba12
ccordoba12 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks @dalthviz!

@dalthviz
Copy link
Member Author

dalthviz commented Nov 4, 2022

Note: Some tests where failing due to the subrepo update of the python-lsp-server, however, talking with Ryan, the thing making the conda-based installers workflows to fail was also not having that subrepo updated. Besides that we needed to patch the spyder-feedstock recipe dependencies to take into account when building the spyder conda package the new requirements contraints.

Thanks @mrclary for helping me to fully understand what was happening here!

@dalthviz
Copy link
Member Author

dalthviz commented Nov 4, 2022

Merging this one to proceed with the release

@dalthviz dalthviz merged commit 51a0e36 into spyder-ide:5.x Nov 4, 2022
dalthviz added a commit that referenced this pull request Nov 4, 2022
@dalthviz
Merge from 5.x: PR #19978
2dea88a 
Fixes #19893
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
type:Task
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dalthviz @ccordoba12